Page MenuHomeMiraheze

BlueLL & WikimediaAPIPortal skins
Closed, DeclinedPublic

Description

  • BlueLL is a skin made by Lingua Libre, a project from Wikimedia France.
    • It doesn't have a page on MW.org, but it does have a repo on GitHub, and it seems it was updated very recently, especially considering this is, technically, a Wikimedia-related project.
    • I don't think the skin has any specific custom parameters that need to be added to ManageWiki, but it's still good to check that.
  • WikimediaApiPortal is an official skin from Wikimedia used on their API documentation/reference wiki. It has been updated very recently and it looks very good imo.
    • While the skin (on MW.org) is classified under "beta", I don't think there should be any issues with that, especially considering we already have some beta-status skins;
    • Please read the MW.org page and analyse the variables applied by the skin on LocalSettings.php, so it can be decided whether these settings should be on ManageWiki or not.

Event Timeline

Herald added subscribers: Unknown Object (User), Bongo-Cat, Unknown Object (User) and 2 others. · View Herald TranscriptDec 28 2021, 18:10
Unknown Object (User) added a comment.Dec 29 2021, 05:59

Based off the way BlueLL is designed I have doubts it'll even work on the latest MW, and PHP. But if it does, approved.

As for WikimediaApiPortal, that one is to Wikimedia specific to approve and has been declined for that reason in the past.

Unknown Object (User) added a comment.Dec 29 2021, 06:01

Actually, I'm taking another look at BlueLL, there's some real code standards issues I have with it, as well as some potential (albeit minor) security issues with it.

Based off the way BlueLL is designed I have doubts it'll even work on the latest MW, and PHP. But if it does, approved.

As for WikimediaApiPortal, that one is to Wikimedia specific to approve and has been declined for that reason in the past.

are there other issues with WikimediaApiPortal aside from the logo? Because I don't think the wordmark alone should be a reason to decline, as there are skins (Nimbus iirc) that have "ShoutWiki" printed all over the place, and were approved without much problems if I'm not mistaken.

Unknown Object (User) added a comment.Dec 29 2021, 16:39

For Nimbus I want to do an upstream PR to make that configurable also. As I don't like that either.

Lakelimbo lowered the priority of this task from Normal to Low.Dec 30 2021, 01:46

I'll lower the priority so you can take more time to analyse each one

Unknown Object (User) raised the priority of this task from Low to Normal.Jan 14 2022, 02:35
Unknown Object (User) moved this task from Unsorted to Short Term on the Universal Omega board.

OK, so I've had a look. I'm going to go ahead and approve BlueLL. I am however very reluctant to approve WikimediaAPIPortal, due to it being so Wikimedia specific (even with the name of it), I would recommend that it be declined due to that, however due to me not declining it on grounds of security, I will leave that decision to the rest of Technology-Team (MediaWiki).

Unknown Object (User) moved this task from Backlog to Actions Needed (Review) on the Extensions board.Jan 14 2022, 02:35

I would agree that WikimediaApiPortal seems to WMF specific and we have declined extensions for that reason in the past.

it's ok, if someday it becomes less WMF-specific, I will made another request for review.

Unknown Object (User) closed this task as Declined.Jan 16 2022, 16:55
Unknown Object (User) claimed this task.

Thank you for understanding!