Page MenuHomeMiraheze

AutoPromote can cause a wiki to OOM
Closed, ResolvedPublic

Description

Today I discovered that by setting:

MariaDB [mhglobal]> update mw_permissions set perm_autopromote = '["!",8,9]' where perm_dbname = 'pkvastwiki' and perm_group = 'user';

can lead to the site 502'ing when logging in and causing memory issues:

[14-Dec-2020 15:12:58 UTC] PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /srv/mediawiki/w/includes/user/UserGroupManager.php on line 480

this is what it looks like when you have the above auto promote set

Screenshot 2020-12-14 at 15.39.48.png (1×3 px, 431 KB)

Event Timeline

Note that I found this issue when debugging T6551 and discovered it was autopromote causing the issue.

John claimed this task.

ManageWiki allows setting via the interface what MediaWiki allows. This sounds like either a downstream Miraheze issue or an upstream MediaWiki issue and not a ManageWiki issue.

Paladox edited projects, added MediaWiki; removed ManageWiki.
RhinosF1 changed the task status from Open to Stalled.Dec 15 2020, 09:32
RhinosF1 added projects: Upstream, MediaWiki.

https://phabricator.wikimedia.org/T270145

Stalling and leaving private. This is waiting on upstream ticket.

RhinosF1 moved this task from Radar to Bugs on the Site Reliability Engineering board.
RhinosF1 added a project: Security.

Adding sec as it's a sec issue

John removed John as the assignee of this task.Dec 15 2020, 13:27
RhinosF1 assigned this task to Paladox.

Fix deployed. Can be made public once upstream do.

RhinosF1 changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 18 2020, 08:24
RhinosF1 changed the edit policy from "Custom Policy" to "All Users".