Page MenuHomeMiraheze

Add wiki_settings column to cw_wikis table
Closed, ResolvedPublic


A wiki_settings column should be added to the cw_wikis. I think a MEDIUMTEXT is sufficient here.

Event Timeline

Southparkfan raised the priority of this task from Normal to High.Aug 28 2016, 20:57

An attempt to do this via pt-online-schema-change failed a few days ago, and resulted in an OOM with 3 minutes downtime.

The cause should be investigated (what is the bad query?), reported upstream (MariaDB? Percona?), and due to the high importance of this schema change (blocker for a goal), for now a regular ALTER should be used. This will mean the dblist cronjobs should be stopped, and CreateWiki should be disabled (read/write on cw_wikis won't work).

John closed this task as Resolved.EditedAug 30 2016, 17:02
John claimed this task.

MariaDB [metawiki]> ALTER TABLE cw_wikis ADD COLUMN wiki_settings MEDIUMTEXT NULL;
Query OK, 0 rows affected (0.06 sec)

This is done from my perspective. I've added it to cw_wikis.sql. Since you never shared the original query, I can't debug your issues and my query may vary massively from what you wanted but you can just ALTER mine now.

Also keep in mind all the information you shared with "wiki_settings" and MEDIUMTEXT so that's all I've done.