Page MenuHomeMiraheze

Install “Fluent” theme on wanderingstars.miraheze.org
Open, Stalled, LowPublic

Description

Hello, could I please get the following theme installed on my wiki at wanderingstars.miraheze.org?

Immewnity’s “Fluent” theme:
https://www.mediawiki.org/wiki/Skin:Fluent

Event Timeline

Redmin triaged this task as Normal priority.Dec 24 2023, 18:57
Redmin added a project: Extensions.

This will still need a security review, but in the interim, there are issues precluding this from working on MW 1.39+ due to using methods which have been removed. I have opened a PR to remove these, but the skin will need a review once they are fixed.

PR has been merged, but still awaiting a security review before it can be added to ManageWiki. If someone wants to ping me once it has been reviewed I'll add it :)

Redmin removed Redmin as the assignee of this task.Jan 23 2024, 19:06
Redmin moved this task from Security Review Needed to Reviewed, Approved on the Extensions board.
Redmin added a project: CSP Review.

This will now need a CSP review as the skin loads styles from an external website by default.

This potentially can't be installed due to how the skin is in a sub directory, which doesn't necessarily work with our setup but maybe I can fix support for it.

I found some easy issues on the skin's issue tracker and will be working on them for a while. I will also try to see if I can get that CDN changed to jsdelivr, which is in our CSP, let's see what the maintainer thinks.

OrangeStar changed the task status from Open to Stalled.Jan 28 2024, 12:44
OrangeStar added a project: Upstream.

This potentially can't be installed due to how the skin is in a sub directory, which doesn't necessarily work with our setup but maybe I can fix support for it.

Skin is now on the root of the repo.

I've PR'd to fix all of those issues.

The maintainer said that the skin will bundle the CSS it currently downloads from sharepointonline in the skin (https://github.com/immewnity/mediawiki-fluent/issues/16#issuecomment-1915868645), so a CSP review will likely not be necessary after all.

CSS is now bundled in the skin (https://github.com/immewnity/mediawiki-fluent/commit/331d9a6c98f92c8dff5d1b6a89030ea97dc56614). Not sure if there are any blockers left. Thanks @Original_Authority for fixing my mess with the Gravatar stuff :p.
EDIT: Oops, forgot about #13.

@Original_Authority could you confirm that there are no blockers left?

@Original_Authority could you confirm that there are no blockers left?

+1 from me. The only qualm I have is that this line could be somewhat confusing.

For example if I set $wgFluentDisableGravatar to true, it would actually load the Gravatar. Either the if/else needs to be switched around, or the variables need renaming. I think this is potentially an issue I have introduced, so if nobody beats me to It I'll open a PR to fix it tonight. But from all other standpoints, this is fine.

Universal_Omega changed the task status from Stalled to Open.Mar 23 2024, 07:01
Universal_Omega lowered the priority of this task from Normal to Low.

Please raise back to 'normal' when the blocker is resolved and this is no longer stalled.

Universal_Omega changed the task status from Open to Stalled.Mar 23 2024, 07:05

Whoops...